chore: Add size-limit check for app layout widget entry points #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
force-pushed
the
size-limit-widget
branch
from
18c046e
to
2332eb2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
========================================
Coverage 96.28% 96.28%
========================================
Files 769 769
Lines 21776 21776
Branches 7043 7453 +410
========================================
Hits 20966 20966
+ Misses 802 757 -45
- Partials 8 53 +45 ☔ View full report in Codecov by Sentry. |
just-boris
commented
Nov 11, 2024
| "lib/components/side-navigation/implementation.js", | ||
| "lib/components/help-panel/implementation.js" | ||
| ], | ||
| "limit": "140 kB" |
There was a problem hiding this comment.
Currently sits on 132.62 kB
taheramr
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the build fail, if assets to bundle in app layout widget grow too high
Related links, issue #, if available: n/a
How has this been tested?
PR build passes
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.